Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/5694#issuecomment-101726519
> could I get a few eyes on this one?
Doesn't look like you've made any big changes since my last review, so I
can say this patch LGTM overall.
You more recent commit mentions
[SPARK-6908](https://issues.apache.org/jira/browse/SPARK-6908); I'm guessing
you pulled those changes [from
here](https://github.com/apache/spark/pull/5876/files#diff-3dc5ad3a9953df8025880bf443153d6e).
You might also want to incorporate the changes proposed in #5955 by @yhuai.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
