cloud-fan commented on a change in pull request #35188:
URL: https://github.com/apache/spark/pull/35188#discussion_r810039104
##########
File path:
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala
##########
@@ -178,7 +178,12 @@ abstract class FileCommitProtocol extends Logging {
* implementation deletes the file immediately.
*/
def deleteWithJob(fs: FileSystem, path: Path, recursive: Boolean): Boolean =
{
- fs.delete(path, recursive)
+ if (fs.getConf.getInt("fs.trash.interval", 0) > 0 &&
Review comment:
Where can I find the document of `fs.trash.interval`? It's better to add
a comment to link to the hadoop conf, to explain that this conf indicates
enabling the trash feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
