c21 commented on a change in pull request #35574:
URL: https://github.com/apache/spark/pull/35574#discussion_r810572989
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
##########
@@ -524,10 +543,7 @@ case class HashShuffleSpec(
// will add shuffles with the default partitioning of
`ClusteredDistribution`, which uses all
// the join keys.
if
(SQLConf.get.getConf(SQLConf.REQUIRE_ALL_CLUSTER_KEYS_FOR_CO_PARTITION)) {
- partitioning.expressions.length == distribution.clustering.length &&
- partitioning.expressions.zip(distribution.clustering).forall {
- case (l, r) => l.semanticEquals(r)
- }
+ partitioning.isPartitionedOnFullKeys(distribution)
Review comment:
I think we probably need strict order here, as it feels more safer with
requiring of order, and this is the original behavior when join requires
`HashClusteredDistribution`. This essentially restores the join's behavior to
what it was with `HashClusteredDistribution`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
