Yikun edited a comment on pull request #35557:
URL: https://github.com/apache/spark/pull/35557#issuecomment-1046609601


   @dongjoon-hyun I think I understand the reason why this error only happened 
in `docker-desktop` after 5.12.1 upgrade, there should be two bugs in current 
spark repo.
   
   1. Before K8S client v5.12.1 (5.12.0 in spark), `autoConfigure` with `null` 
will overwrite `autoConfigure` with specified context. 
https://github.com/fabric8io/kubernetes-client/commit/81c11ca5c2044eac2cbebe5107945ec95011e8f4
   2. Wrong context name in `docker-desktop` backend test on kubernetes test. 
https://github.com/apache/spark/pull/35595
   
   These two bugs let "two negatives make a positive", that means the 
docker-backend integration test will never use `docker-for-desktop` as context 
input, because it use env current context instead of.
   
   See 
[here](https://github.com/fabric8io/kubernetes-client/blob/677884ca88f3911f9b41ec919db152d441ad2cdd/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/Config.java#L591-L596)
 as reference, if we already call `autoConfigure(config, null)`, the 
`autoConfigure(config, context)` will not work).
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to