Yikun commented on a change in pull request #35595:
URL: https://github.com/apache/spark/pull/35595#discussion_r810927983
##########
File path:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PVTestsSuite.scala
##########
@@ -71,7 +71,7 @@ private[spark] trait PVTestsSuite { k8sSuite: KubernetesSuite
=>
.withMatchExpressions(new NodeSelectorRequirementBuilder()
.withKey("kubernetes.io/hostname")
.withOperator("In")
- .withValues("minikube", "m01", "docker-for-desktop",
"docker-desktop")
+ .withValues("minikube", "m01", "docker-desktop")
Review comment:
Note: `docker-for-desktop` was already [renamed
to](https://github.com/docker/for-mac/issues/4089) `docker-desktop` since
docker desktop 2.4 for win and mac, so we can drop `docker-for-desktop` in here
safely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
