Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6090#discussion_r30254586
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/sources/commands.scala ---
@@ -293,9 +293,18 @@ private[sql] abstract class BaseWriterContainer(
}
private def newOutputCommitter(context: TaskAttemptContext):
OutputCommitter = {
- outputFormatClass.newInstance().getOutputCommitter(context)
+ val committerClass = context.getConfiguration.getClass(
+ "mapred.output.committer.class", null, classOf[OutputCommitter])
+
+ Option(committerClass).map { clazz =>
+ val ctor = clazz.getDeclaredConstructor(classOf[Path],
classOf[TaskAttemptContext])
--- End diff --
Actually, in `InsertIntoFSBasedRelation.run`, we already set the the output
path through `FileOutputFormat.setOutputPath(job, qualifiedOutputPath)`. So,
the output path should be set in `context`. Seems we do not need to change
`newOutputCommitter` at all, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
