ulysses-you commented on a change in pull request #35473:
URL: https://github.com/apache/spark/pull/35473#discussion_r811192145
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -1407,7 +1441,6 @@ object EliminateSorts extends Rule[LogicalPlan] {
_.containsPattern(SORT))(applyLocally)
private val applyLocally: PartialFunction[LogicalPlan, LogicalPlan] = {
- case Sort(_, _, child) if child.maxRows.exists(_ <= 1L) =>
recursiveRemoveSort(child)
Review comment:
I think it is. The `EliminateLimits` only run `Once` , and the added
rule run `fixedPoint`. It's no harmful since we have transformWithPruning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
