cloud-fan commented on a change in pull request #35460:
URL: https://github.com/apache/spark/pull/35460#discussion_r811638706



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
##########
@@ -401,6 +405,29 @@ object ShuffleExchangeExec {
     dependency
   }
 
+  /**
+   * Checks if the shuffle partitioning contains indeterminate 
expression/reference.
+   */
+  private def isPartitioningIndeterminate(partitioning: Partitioning, plan: 
SparkPlan): Boolean = {

Review comment:
       For example, `Filter(rand_cond, Project(a, b, c, ...))`. I think all the 
columns are nondeterministic after `Filter`, even though attributes `a`, `b` 
and `c` are deterministic.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to