kevins-29 commented on a change in pull request #35613:
URL: https://github.com/apache/spark/pull/35613#discussion_r812636262
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala
##########
@@ -384,17 +385,31 @@ abstract class SparkPlan extends QueryPlan[SparkPlan]
with Logging with Serializ
val bis = new ByteArrayInputStream(bytes)
val ins = new DataInputStream(codec.compressedInputStream(bis))
- new Iterator[InternalRow] {
+ new NextIterator[InternalRow] {
+ Option(TaskContext.get()).foreach(_.addTaskCompletionListener[Unit](_ =>
closeIfNeeded()))
private var sizeOfNextRow = ins.readInt()
Review comment:
Both `NextIterator` and `CompletionIterator` suffer from the same
limitation, ie. if the consumer of the Iterator does not consume the Iterator
in its entirety, either because of an exception when processing an item or when
using a method like `Iterator.find` for example, then neither will call `close`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
