gengliangwang commented on a change in pull request #35629:
URL: https://github.com/apache/spark/pull/35629#discussion_r812783499
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -361,15 +361,19 @@ case class Elt(
ev.copy(
code"""
|${index.code}
- |final int $indexVal = ${index.value};
- |${CodeGenerator.JAVA_BOOLEAN} $indexMatched = false;
- |$inputVal = null;
- |do {
- | $codes
- |} while (false);
- |$indexOutOfBoundBranch
- |final ${CodeGenerator.javaType(dataType)} ${ev.value} = $inputVal;
- |final boolean ${ev.isNull} = ${ev.value} == null;
+ |boolean ${ev.isNull} = ${index.isNull};
+ |${CodeGenerator.javaType(dataType)} ${ev.value} = null;
+ |if (!${index.isNull}) {
Review comment:
If the index is null, skip the following loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
