dongjoon-hyun commented on a change in pull request #35622:
URL: https://github.com/apache/spark/pull/35622#discussion_r813392128
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala
##########
@@ -48,42 +50,23 @@ package object util extends Logging {
def fileToString(file: File, encoding: Charset = UTF_8): String = {
val inStream = new FileInputStream(file)
- val outStream = new ByteArrayOutputStream
try {
- var reading = true
- while ( reading ) {
- inStream.read() match {
- case -1 => reading = false
- case c => outStream.write(c)
- }
- }
- outStream.flush()
- }
- finally {
+ new String(ByteStreams.toByteArray(inStream), encoding)
+ } finally {
inStream.close()
}
- new String(outStream.toByteArray, encoding)
+
Review comment:
Shall we delete this empty line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
