aokolnychyi commented on a change in pull request #35395: URL: https://github.com/apache/spark/pull/35395#discussion_r813610190
########## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/RowLevelOperationBuilder.java ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.write; + +import org.apache.spark.annotation.Experimental; + +/** + * An interface for building a {@link RowLevelOperation}. + * + * @since 3.3.0 + */ +@Experimental +public interface RowLevelOperationBuilder { Review comment: I tried to keep the API consistent by following what we did for scans and writes. I think we have mix-in traits to pass extra information to builders (e.g. predicate pushdown). In this case, the produced row-level operation tells Spark whether deltas are supported and what's the row ID. We can't pass the row ID from Spark. For now, we always pass a SQL command and options to builders. My worry is that we may have valid use cases for mix-in traits on the builder for passing extra information in the future. I am happy to discuss, though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
