cloud-fan commented on a change in pull request #35644:
URL: https://github.com/apache/spark/pull/35644#discussion_r813943262
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -2344,8 +2344,11 @@ case class DateDiff(endDate: Expression, startDate:
Expression)
copy(endDate = newLeft, startDate = newRight)
}
+// scalastyle:off line.size.limit
@ExpressionDescription(
- usage = "_FUNC_(year, month, day) - Create date from year, month and day
fields.",
+ usage = """_FUNC_(year, month, day) - Create date from year, month and day
fields.
+ If the configuration `spark.sql.ansi.enabled` is false, the function
returns NULL on invalid inputs. Otherwise, it will throw an error instead.
Review comment:
can you run `DESC FUNCTION` locally and see if the output is reasonable?
IIRC we need to put a super long single-line string for the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]