robreeves commented on pull request #35637: URL: https://github.com/apache/spark/pull/35637#issuecomment-1050061063
> Just out of curiosity, can you explain again the idea that negative = negative + negative? why add the same thing to itself? it looks funny but I'm sure there's a reason it works - may be worth a comment This doesn't add the same number together twice. This refers to the sign (positive or negative) for the composite indices modified in this PR, `TaskDataWrapper.shuffleTotalReads` and `TaskDataWrapper.shuffleTotalBlocks`. The sign is important because tasks that aren't successful should have a negative sign (implemented in PR #26508). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
