cloud-fan commented on a change in pull request #35494:
URL: https://github.com/apache/spark/pull/35494#discussion_r814550112
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -203,30 +219,30 @@ abstract class JdbcDialect extends Serializable with
Logging{
def compileAggregate(aggFunction: AggregateFunc): Option[String] = {
aggFunction match {
case min: Min =>
- val sql = min.column match {
+ min.column match {
Review comment:
we can do `compileExpression(min.column).map(v => s"MIN($v)")` directly
if https://github.com/apache/spark/pull/35494/files#r814549510 is done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
