dongjoon-hyun commented on a change in pull request #35655:
URL: https://github.com/apache/spark/pull/35655#discussion_r815039921
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -3083,6 +3083,17 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val LEGACY_DATETIME_ENCODER_ENABLED =
+ buildConf("spark.sql.legacy.datetimeEncoder.enabled")
+ .doc("If the configuration property is set to true, java.sql.Timestamp
and " +
+ "java.sql.Date are used as external types for " +
+ "Catalyst's TimestampType and DateType in rows encoding and decoding
when the property " +
+ s"${DATETIME_JAVA8API_ENABLED.key} is true (otherwise it is ignored).")
+ .version("3.3.0")
+ .internal()
Review comment:
For the new config name, we had better remove this `internal` because
the parent config is exposed already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
