anchovYu commented on a change in pull request #35654:
URL: https://github.com/apache/spark/pull/35654#discussion_r815043556
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/BooleanSimplificationSuite.scala
##########
@@ -138,8 +138,8 @@ class BooleanSimplificationSuite extends PlanTest with
ExpressionEvalHelper with
'a > 1 && 'b > 3 && 'c > 1)
checkCondition(
- ('a > 1 || 'b > 3) && (('a > 1 || 'b > 3) && 'd > 0 && (('a > 1 || 'b >
3) && 'c > 1)),
- ('a > 1 || 'b > 3) && 'd > 0 && 'c > 1)
+ ('a > 1 || 'b > 3) && (('a > 1 || 'b > 3) && 'd > 0L && (('a > 1 || 'b >
3) && 'c > 1)),
+ ('a > 1 || 'b > 3) && 'd > 0L && 'c > 1)
Review comment:
ANSI mode would cast the d(string) and 0 to long type. @gengliangwang
for more context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
