cloud-fan commented on a change in pull request #35653:
URL: https://github.com/apache/spark/pull/35653#discussion_r815886958
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
##########
@@ -614,7 +614,11 @@ object ViewHelper extends SQLConfHelper with Logging {
}.getOrElse(false)
if (replace && uncache) {
logDebug(s"Try to uncache ${name.quotedString} before replacing.")
- checkCyclicViewReference(analyzedPlan, Seq(name), name)
+ if (!conf.storeAnalyzedPlanForView && originalText.nonEmpty) {
Review comment:
maybe it's better to have a `val storeAnalyzedPlanForView =
conf.storeAnalyzedPlanForView || originalText.nonEmpty` at the beginning, then
we can just write `if (!storeAnalyzedPlanForView)` here and below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
