monkeyboy123 commented on a change in pull request #35662:
URL: https://github.com/apache/spark/pull/35662#discussion_r815950849
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala
##########
@@ -147,7 +147,7 @@ class EquivalentExpressions {
expr.find(_.isInstanceOf[LambdaVariable]).isDefined ||
// `PlanExpression` wraps query plan. To compare query plans of
`PlanExpression` on executor,
// can cause error like NPE.
- (expr.isInstanceOf[PlanExpression[_]] && TaskContext.get != null)
+ (expr.find(_.isInstanceOf[PlanExpression[_]]).isDefined &&
TaskContext.get != null)
Review comment:
> We can also add a UT in `SubexpressionEliminationSuite`, which tests
`addExprTree` directly.
I think add a UT in SubexpressionEliminationSuite is not reasonable, as we
can not access InSubqueryExec in Spark Catalyst module, InSubqueryExec is in
the Spark Sql module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
