dongjoon-hyun commented on a change in pull request #35553:
URL: https://github.com/apache/spark/pull/35553#discussion_r816388289
##########
File path:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/VolcanoTestsSuite.scala
##########
@@ -37,12 +54,82 @@ private[spark] trait VolcanoTestsSuite { k8sSuite:
KubernetesSuite =>
assert(annotations.get("scheduling.k8s.io/group-name") ===
s"$appId-podgroup")
}
- protected def checkPodGroup(pod: Pod): Unit = {
+ protected def checkPodGroup(
+ pod: Pod,
+ queue: Option[String] = None): Unit = {
val appId = pod.getMetadata.getLabels.get("spark-app-selector")
val podGroupName = s"$appId-podgroup"
- val volcanoClient =
kubernetesTestComponents.kubernetesClient.adapt(classOf[VolcanoClient])
val podGroup = volcanoClient.podGroups().withName(podGroupName).get()
assert(podGroup.getMetadata.getOwnerReferences.get(0).getName ===
pod.getMetadata.getName)
+ val spec = podGroup.getSpec
+ if (queue.isDefined) assert(spec.getQueue === queue.get)
Review comment:
```scala
- val spec = podGroup.getSpec
- if (queue.isDefined) assert(spec.getQueue === queue.get)
+ queue.foreach(q => assert(q === podGroup.getSpec.getQueue))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
