Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6083#discussion_r30270895
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -371,6 +371,14 @@ class SparkContext(config: SparkConf) extends Logging 
with ExecutorAllocationCli
           throw new SparkException("An application name must be set in your 
configuration")
         }
     
    +    // System property spark.yarn.app.id must be set if user code ran by 
AM on a YARN cluster
    +    // yarn-standalone is deprecated, but still supported
    +    if ((master == "yarn-cluster" || master == "yarn-standalone") &&
    +        !_conf.contains("spark.yarn.app.id")) {
    --- End diff --
    
    yea, the suggestion was though that this should also be `spark.app.id`, 
since the two usages of `spark.yarn.app.id` are the only two in the code base: 
https://github.com/apache/spark/pull/6120  It might be worth resolving that 
first since it will matter to this change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to