sperlingxx commented on pull request #35708: URL: https://github.com/apache/spark/pull/35708#issuecomment-1056660100
> Hi @sperlingxx, this change look very similar to my suggested change: #32298. Actually, I think your PR is the same as the very first version of my PR was in terms of relying on `ReuseExchangeAndSubquery` to reuse and run combined subqueries only once. But then my PR evolved into using a special root node `CommonScalarSubqueries` to store the combined subqueries and using `ScalarSubqueryReference` expressions as references to the common ones. (Please see conversation with @sigmod why it was required.) Our subquery "merging" logic are a bit different, please check mine as it can handle more complex subqueries. > > cc @cloud-fan Hi @peter-toth, I didn't notice that there exists another ongoing work on the same issue. For sure, compared with this patch, #32298 proposes a more comprehensive apporach to combine scalar subquiries. I will close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
