xinrong-databricks commented on a change in pull request #35706:
URL: https://github.com/apache/spark/pull/35706#discussion_r818317521
##########
File path: python/pyspark/pandas/series.py
##########
@@ -976,9 +976,10 @@ def cov(self, other: "Series", min_periods: Optional[int]
= None) -> float:
else:
return sdf.select(F.covar_samp(*sdf.columns)).head(1)[0][0]
- # TODO: arg should support Series
# TODO: NaN and None
Review comment:
We'd better keep it for empty dict `arg` because of its inconsistency
with pandas. I made the TODO more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
