cloud-fan commented on a change in pull request #35494:
URL: https://github.com/apache/spark/pull/35494#discussion_r818340285
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/H2Dialect.scala
##########
@@ -22,12 +22,33 @@ import java.util.Locale
import org.apache.spark.sql.AnalysisException
import org.apache.spark.sql.catalyst.analysis.{NoSuchNamespaceException,
NoSuchTableException, TableAlreadyExistsException}
+import org.apache.spark.sql.connector.expressions.{Expression, FieldReference}
import org.apache.spark.sql.connector.expressions.aggregate.{AggregateFunc,
GeneralAggregateFunc}
+import org.apache.spark.sql.connector.util.V2ExpressionSQLBuilder
private object H2Dialect extends JdbcDialect {
override def canHandle(url: String): Boolean =
url.toLowerCase(Locale.ROOT).startsWith("jdbc:h2")
+ class H2SQLBuilder extends V2ExpressionSQLBuilder {
+ override def visitFieldReference(fieldRef: FieldReference): String = {
+ if (fieldRef.fieldNames().length != 1) {
+ throw new IllegalArgumentException(
+ "FieldReference with field name has multiple or zero parts
unsupported: " + fieldRef);
Review comment:
Is it only a limitation of H2? I think it's a limitation for all JDBC
dialects today, and it's better to put this special sql builder in
[JdbcDialects.scala](https://github.com/apache/spark/pull/35494/files#diff-1533255ad629a18e883f8186b303fdf4fae99043551ce20c5b5ea06d085e0b14)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
