nyingping commented on a change in pull request #35721:
URL: https://github.com/apache/spark/pull/35721#discussion_r819348736
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/BaseSessionStateBuilder.scala
##########
@@ -242,15 +242,24 @@ abstract class BaseSessionStateBuilder(
* Note: this depends on `catalog` and `experimentalMethods` fields.
*/
protected def optimizer: Optimizer = {
- new SparkOptimizer(catalogManager, catalog, experimentalMethods) {
- override def earlyScanPushDownRules: Seq[Rule[LogicalPlan]] =
- super.earlyScanPushDownRules ++ customEarlyScanPushDownRules
+ val optimizerClassName =
conf.getConfString("spark.sql.customized.optimizer", "")
+ if (optimizerClassName.nonEmpty && !optimizerClassName.equals("")) {
+ val catalogManagerTypeName =
Class.forName("org.apache.spark.sql.connector.catalog.CatalogManager")
+ val sessionCatalogTypeName =
Class.forName("org.apache.spark.sql.catalyst.catalog.SessionCatalog")
+ val experimentalMethodsTypeName =
Class.forName("org.apache.spark.sql.ExperimentalMethods")
+ val optimizerInstance =
Class.forName(optimizerClassName).getConstructor(catalogManagerTypeName,
sessionCatalogTypeName,
experimentalMethodsTypeName).newInstance(catalogManager, catalog,
experimentalMethods)
+ optimizerInstance.asInstanceOf[Optimizer]
+ } else {
+ new SparkOptimizer(catalogManager, catalog, experimentalMethods) {
+ override def earlyScanPushDownRules: Seq[Rule[LogicalPlan]] =
+ super.earlyScanPushDownRules ++ customEarlyScanPushDownRules
- override def preCBORules: Seq[Rule[LogicalPlan]] =
- super.preCBORules ++ customPreCBORules
+ override def preCBORules: Seq[Rule[LogicalPlan]] =
+ super.preCBORules ++ customPreCBORules
Review comment:
nit. redundant space on line 257,258.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
