jiangxb1987 commented on a change in pull request #35041:
URL: https://github.com/apache/spark/pull/35041#discussion_r819839061
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
##########
@@ -1301,7 +1301,7 @@ class PlanParserSuite extends AnalysisTest {
"timestamp expression cannot contain subqueries")
}
- test("PERCENTILE_CONT function") {
+ test("PERCENTILE_CONT & PERCENTILE_DISC") {
def assertPercentileContPlans(inputSQL: String, expectedExpression:
Expression): Unit = {
Review comment:
nit: rename this function to `assertPercentileBasePlans` ?
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/percentiles.scala
##########
@@ -324,3 +337,100 @@ case class Percentile(
frequencyExpression = newThird
)
}
+
+/**
+ * The Percentile aggregate function returns a percentile(s) based on a
discrete distribution of
Review comment:
`a percentile(s)` -> `the percentile(s)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
