srowen commented on a change in pull request #35732:
URL: https://github.com/apache/spark/pull/35732#discussion_r820349472
##########
File path:
common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDBIterator.java
##########
@@ -197,7 +197,6 @@ public synchronized void close() throws IOException {
* when Scala wrappers are used, this makes sure that, hopefully, the JNI
resources held by
* the iterator will eventually be released.
*/
- @SuppressWarnings("deprecation")
Review comment:
Oh, do warnings pop back up? I thought these were found to not suppress
anything? if it still emits a warning without it, we should keep it. For
example, yeah, isn't finalize() definitely deprecated as of 11?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
