cloud-fan commented on a change in pull request #35707:
URL: https://github.com/apache/spark/pull/35707#discussion_r820466576
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisTest.scala
##########
@@ -200,11 +200,15 @@ trait AnalysisTest extends PlanTest {
}
}
- protected def interceptParseException(
- parser: String => Any)(sqlCommand: String, messages: String*): Unit = {
+ protected def interceptParseException(parser: String => Any)(
+ sqlCommand: String, messages: String*)(
+ errorClass: Option[String] = None): Unit = {
Review comment:
nit: in other places, we just add the `errorClass` parameter before the
`messages` parameter, e.g. `def intercept(sqlCommand: String, errorClass:
Option[String], messages: String*)`, but why do we add a curry constructor here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
