cloud-fan commented on a change in pull request #35727:
URL: https://github.com/apache/spark/pull/35727#discussion_r820673913
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -99,6 +100,27 @@ abstract class JdbcDialect extends Serializable with
Logging{
*/
def getJDBCType(dt: DataType): Option[JdbcType] = None
+ /**
+ * Returns a factory for creating connections to the given JDBC URL.
+ * In general, creating a connection has nothing to do with JDBC partition
id.
+ * But sometimes it is needed, such as a database with multiple shard nodes.
+ * @param options - JDBC options that contains url, table and other
information.
+ * @return The factory method for creating JDBC connections.
Review comment:
```suggestion
* @return The factory method for creating JDBC connections with the RDD
partition ID. -1 means
the connection is being created at the driver side.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
