cloud-fan commented on a change in pull request #35691:
URL: https://github.com/apache/spark/pull/35691#discussion_r820826136
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PruneFileSourcePartitions.scala
##########
@@ -125,7 +125,8 @@ private[sql] object PruneFileSourcePartitions
getPartitionKeyFiltersAndDataFilters(scan.sparkSession, v2Relation,
scan.readPartitionSchema, filters, output)
// The dataFilters are pushed down only once
- if (partitionKeyFilters.nonEmpty || (dataFilters.nonEmpty &&
scan.dataFilters.isEmpty)) {
+ if ((partitionKeyFilters.nonEmpty && dataFilters.isEmpty)
Review comment:
dump question: how does this guarantee only-once?
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PruneFileSourcePartitions.scala
##########
@@ -125,7 +125,8 @@ private[sql] object PruneFileSourcePartitions
getPartitionKeyFiltersAndDataFilters(scan.sparkSession, v2Relation,
scan.readPartitionSchema, filters, output)
// The dataFilters are pushed down only once
- if (partitionKeyFilters.nonEmpty || (dataFilters.nonEmpty &&
scan.dataFilters.isEmpty)) {
+ if ((partitionKeyFilters.nonEmpty && dataFilters.isEmpty)
Review comment:
dumb question: how does this guarantee only-once?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
