itholic opened a new pull request #35757:
URL: https://github.com/apache/spark/pull/35757


   ### What changes were proposed in this pull request?
   
   This followup for https://github.com/apache/spark/pull/35488 proposes to fix 
ANSI conf check properly in `python/pyspark/pandas/utils.py`.
   
   
   
   ### Why are the changes needed?
   
   So far, the condition `if spark.conf.get("spark.sql.ansi.enabled"):` always 
went True, since `spark.conf.get("spark.sql.ansi.enabled")` returns `"true"` or 
`"false"` instead of `True` or `False`.
   
   So, it's always show the warning message although the ANSI mode is not 
enabled.
   
   We might need to check the returned string properly so that we can only show 
the warning message when the `"spark.sql.ansi.enabled"` is actually set as True.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Now users see warning message when only `"spark.sql.ansi.enabled"` is set as 
True.
   
   
   ### How was this patch tested?
   
   Manually test, and the existing tests are should be passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to