srowen commented on a change in pull request #34855:
URL: https://github.com/apache/spark/pull/34855#discussion_r821323085
##########
File path: dev/deps/spark-deps-hadoop-3-hive-2.3
##########
@@ -121,10 +120,11 @@ janino/3.0.16//janino-3.0.16.jar
javassist/3.25.0-GA//javassist-3.25.0-GA.jar
javax.jdo/3.2.0-m3//javax.jdo-3.2.0-m3.jar
javolution/5.5.1//javolution-5.5.1.jar
+jaxb-api/2.2.11//jaxb-api-2.2.11.jar
Review comment:
this is CDDL 1.0 - see below for license tasks
##########
File path: dev/deps/spark-deps-hadoop-3-hive-2.3
##########
@@ -121,10 +120,11 @@ janino/3.0.16//janino-3.0.16.jar
javassist/3.25.0-GA//javassist-3.25.0-GA.jar
javax.jdo/3.2.0-m3//javax.jdo-3.2.0-m3.jar
javolution/5.5.1//javolution-5.5.1.jar
+jaxb-api/2.2.11//jaxb-api-2.2.11.jar
jaxb-runtime/2.3.2//jaxb-runtime-2.3.2.jar
jcl-over-slf4j/1.7.32//jcl-over-slf4j-1.7.32.jar
jdo-api/3.0.1//jdo-api-3.0.1.jar
-jdom/1.1//jdom-1.1.jar
+jdom2/2.0.6//jdom2-2.0.6.jar
Review comment:
I'm checking licenses of these too - this is basically 3-clause BSD and
could be listed as such in the LICENSE/NOTICE file with other 3-clause BSD. I
think we might need the license file stored in licenses/ -
https://raw.githubusercontent.com/hunterhacker/jdom/master/LICENSE.txt
##########
File path: hadoop-cloud/pom.xml
##########
@@ -267,6 +267,13 @@
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</exclusion>
+ <exclusion>
+ <!--
+ This is a code coverage library introduced by
aliyun-java-sdk-core, only for testing
+ -->
+ <groupId>org.jacoco</groupId>
+ <artifactId>org.jacoco.agent</artifactId>
Review comment:
OK yeah I think we can safely exclude it. Probably a mistake that it
wasn't test-scope in the original artifact
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
