cloud-fan commented on a change in pull request #35531:
URL: https://github.com/apache/spark/pull/35531#discussion_r821676658
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -890,7 +890,7 @@ primaryExpression
| OVERLAY '(' input=valueExpression PLACING replace=valueExpression
FROM position=valueExpression (FOR length=valueExpression)? ')'
#overlay
| PERCENTILE_CONT '(' percentage=valueExpression ')'
- WITHIN GROUP '(' ORDER BY sortItem ')'
#percentile
+ WITHIN GROUP '(' ORDER BY sortItem ')' ( OVER windowSpec)?
#percentile
Review comment:
I'd like to understand the rationale more. This function has its own
syntax to specify ORDER BY, so I get that it should not co-exists with the
ORDER BY in the window frame. But doesn't `percentile` have the same problem
when being used as a window function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
