cloud-fan commented on a change in pull request #35771:
URL: https://github.com/apache/spark/pull/35771#discussion_r821845620
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/TransposeWindowSuite.scala
##########
@@ -90,14 +90,16 @@ class TransposeWindowSuite extends PlanTest {
}
test("don't transpose two adjacent windows with intersection of partition
and output set") {
- val query = testRelation
- .window(Seq(('a + 'b).as('e), sum(c).as('sum_a_2)), partitionSpec3,
Seq.empty)
- .window(Seq(sum(c).as('sum_a_1)), Seq(a, 'e), Seq.empty)
+ if (!conf.ansiEnabled) {
+ val query = testRelation
+ .window(Seq(('a + 'b).as('e), sum(c).as('sum_a_2)), partitionSpec3,
Seq.empty)
Review comment:
I don't think this test case want to test type coercion. Can we add
explicit cast or use other string expressions like `concat('a, 'b)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
