c21 commented on a change in pull request #35686:
URL: https://github.com/apache/spark/pull/35686#discussion_r821952163
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##########
@@ -780,10 +806,13 @@ private[execution] final class LongToUnsafeRowMap(val mm:
TaskMemoryManager, cap
* Update the address in array for given key.
*/
private def updateIndex(key: Long, address: Long): Unit = {
+ numKeyLookups += 1
+ numProbes += 1
Review comment:
@cloud-fan - This is the same behavior for `UnsafeHashedRelation`, while
[when it builds hash
relation](https://github.com/apache/spark/blob/master/sql%2Fcore%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Fexecution%2Fjoins%2FHashedRelation.scala#L479),
it [updates the lookup/probe metrics as
well](https://github.com/apache/spark/blob/master/core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fspark%2Funsafe%2Fmap%2FBytesToBytesMap.java#L528-L533).
I guess it would be good to keep consistent between `UnsafeHashedRelation` and
`LongHashedRelation` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
