dongjoon-hyun commented on a change in pull request #35772:
URL: https://github.com/apache/spark/pull/35772#discussion_r822238657
##########
File path: resource-managers/kubernetes/integration-tests/README.md
##########
@@ -288,6 +288,16 @@ The following is an example to rerun tests with the
pre-built image.
-Dspark.kubernetes.test.imageTag=2022-03-06 \
'kubernetes-integration-tests/runIts'
+You can also specify your specific dockerfile to build JVM/Python/R based
image to test:
+
+ build/sbt -Psparkr -Pkubernetes -Pkubernetes-integration-tests \
+ -Dtest.exclude.tags=minikube \
+ -Dspark.kubernetes.test.deployMode=docker-desktop \
+ -Dspark.kubernetes.test.DockerFile=/path/to/Dockerfile \
+ -Dspark.kubernetes.test.pyDockerFile=/path/to/Dockerfile.py \
+ -Dspark.kubernetes.test.rDockerFile=/path/to/Dockerfile.r \
+ 'kubernetes-integration-tests/test'
Review comment:
Although this is a minor comment, it would be great to be consistent
with the above examples.
- First, this is not setting `deployMode=docker-desktop`. If then, why do we
have `-Dtest.exclude.tags=minikube`?
- Second, in the same way, we had better use
`-Dspark.kubernetes.test.imageTag=2022-03-06` consistently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
