zhengruifeng commented on a change in pull request #35694:
URL: https://github.com/apache/spark/pull/35694#discussion_r822254576
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
##########
@@ -246,6 +246,16 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
extends Product with Tre
children.foldLeft(Option.empty[BaseType]) { (l, r) => l.orElse(r.find(f)) }
}
+ /**
+ * Test whether there is [[TreeNode]] satisfies the conditions specified in
`f`.
+ * The condition is recursively applied to this node and all of its children
(pre-order).
+ */
+ def exists(f: BaseType => Boolean): Boolean = if (f(this)) {
Review comment:
is it possible to make `f` a `PartialFunction[BaseType, Boolean]` and
futher simplify some places like
```
e.exists {
case s: ScalarSubquery => s.isCorrelated
case _ => false
}
```
to
```
e.exists { case s: ScalarSubquery => s.isCorrelated }
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
