cloud-fan commented on a change in pull request #35779:
URL: https://github.com/apache/spark/pull/35779#discussion_r822775145
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RemoveRedundantAggregatesSuite.scala
##########
@@ -153,8 +150,14 @@ class RemoveRedundantAggregatesSuite extends PlanTest {
comparePlans(optimized, expected)
}
+ test("Remove redundant aggregate - upper has contains foldable expressions")
{
+ val originalQuery = x.groupBy('a, 'b)('a, 'b).groupBy('a)('a,
TrueLiteral).analyze
Review comment:
ah this works because these two aggregates are adjacent. If they are
not, we have a problem.
I'm thinking that we should refine `Aggregate.groupOnly`: `.groupBy('a)('a,
TrueLiteral)` is also group only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
