cloud-fan commented on a change in pull request #35768:
URL: https://github.com/apache/spark/pull/35768#discussion_r822782150
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
##########
@@ -36,8 +37,12 @@ public String build(Expression expr) {
return visitFieldReference((FieldReference) expr);
} else if (expr instanceof GeneralScalarExpression) {
GeneralScalarExpression e = (GeneralScalarExpression) expr;
+ List<String> children;
String name = e.name();
switch (name) {
+ case "IN":
+ children = Arrays.stream(e.children()).map(c ->
build(c)).collect(Collectors.toList());
Review comment:
nit: it seems cleaner to make `children` a local variable here:
`List<String> children = Arrays.stream...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
