[GitHub] [spark] dcoliversun commented on pull request #35758: [SPARK-38439][CORE][SQL] add braces with if,else,for,do and while statements

Wed, 09 Mar 2022 18:00:47 -0800 


dcoliversun commented on pull request #35758:
URL: https://github.com/apache/spark/pull/35758#issuecomment-1063575021


   @HyukjinKwon 
   Thanks for your sharing. The information you provide can prove the value of 
my PR.
   
   * [Oracle's Java code 
conventions](https://www.oracle.com/java/technologies/javase/codeconventions-contents.html)
   
![image](https://user-images.githubusercontent.com/44011673/157573090-579782fd-7d61-4ea6-9538-688c70f7dc67.png)
   
![image](https://user-images.githubusercontent.com/44011673/157573131-38317fe3-1dda-4ef2-a91c-28689447c8a8.png)
   
![image](https://user-images.githubusercontent.com/44011673/157573158-0120e51c-6864-4387-8ac6-65e3b6032a83.png)
   * [Scala Control 
Structures](https://docs.scala-lang.org/style/control-structures.html)
   
![image](https://user-images.githubusercontent.com/44011673/157573268-1aacf13f-38cd-46d4-af0d-f372900361bd.png)
   
   It looks like this is necessary to add braces.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to