dongjoon-hyun commented on a change in pull request #35786:
URL: https://github.com/apache/spark/pull/35786#discussion_r823366653
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/VolcanoFeatureStep.scala
##########
@@ -44,12 +44,8 @@ private[spark] class VolcanoFeatureStep extends
KubernetesDriverCustomFeatureCon
override def getAdditionalPreKubernetesResources(): Seq[HasMetadata] = {
val client = new DefaultVolcanoClient
-
- val template = if (kubernetesConf.isInstanceOf[KubernetesDriverConf]) {
- kubernetesConf.get(KUBERNETES_DRIVER_PODGROUP_TEMPLATE_FILE)
- } else {
- kubernetesConf.get(KUBERNETES_EXECUTOR_PODGROUP_TEMPLATE_FILE)
- }
+ // Currently only driver/job-level PodGroup is supported
+ val template = kubernetesConf.get(KUBERNETES_DRIVER_PODGROUP_TEMPLATE_FILE)
Review comment:
This will work incorrectly because this class uses `with
KubernetesExecutorCustomFeatureConfigStep`. I'd suggest to throw exception in
the previous `if .. else ..` statement structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
