cloud-fan commented on a change in pull request #35768:
URL: https://github.com/apache/spark/pull/35768#discussion_r823414344
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala
##########
@@ -175,6 +175,27 @@ object JDBCRDD extends Logging {
requiredColumns: Array[String],
filters: Array[Filter],
parts: Array[Partition],
+ options: JDBCOptions): RDD[InternalRow] = {
+ val url = options.url
+ val dialect = JdbcDialects.get(url)
+ val quotedColumns = requiredColumns.map(colName =>
dialect.quoteIdentifier(colName))
+ new JDBCRDD(
+ sc,
+ dialect.createConnectionFactory(options),
+ pruneSchema(schema, requiredColumns),
+ quotedColumns,
+ filters,
+ parts,
+ url,
+ options)
+ }
+
+ def scanTable(
Review comment:
why do we have 2 `scanTable`? I think JDBC V2 should either support v1
or v2 filter, not both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
