HyukjinKwon commented on a change in pull request #35798:
URL: https://github.com/apache/spark/pull/35798#discussion_r823589894
##########
File path: R/pkg/tests/fulltests/test_sparkSQL.R
##########
@@ -2051,13 +2051,19 @@ test_that("date functions on a DataFrame", {
})
test_that("SPARK-37108: expose make_date expression in R", {
Review comment:
With ANSI:
https://github.com/HyukjinKwon/spark/runs/5493047129?check_suite_focus=true
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2706,7 +2706,7 @@ object SQLConf {
"standard directly, but their behaviors align with ANSI SQL's style")
.version("3.0.0")
.booleanConf
- .createWithDefault(false)
+ .createWithDefault(true)
Review comment:
```suggestion
.createWithDefault(false)
```
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2706,7 +2706,7 @@ object SQLConf {
"standard directly, but their behaviors align with ANSI SQL's style")
.version("3.0.0")
.booleanConf
- .createWithDefault(false)
+ .createWithDefault(true)
Review comment:
I will revert this back once it verifies the test passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
