cloud-fan commented on a change in pull request #35805:
URL: https://github.com/apache/spark/pull/35805#discussion_r824407104
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4
##########
@@ -808,8 +808,8 @@ valueExpression
primaryExpression
: name=(CURRENT_DATE | CURRENT_TIMESTAMP | CURRENT_USER)
#currentLike
- | name=(TIMESTAMPADD | DATEADD | DATE_ADD) LEFT_PAREN unit=identifier
COMMA unitsAmount=valueExpression COMMA timestamp=valueExpression RIGHT_PAREN
#timestampadd
- | name=(TIMESTAMPDIFF | DATEDIFF | DATE_DIFF) LEFT_PAREN unit=identifier
COMMA startTimestamp=valueExpression COMMA endTimestamp=valueExpression
RIGHT_PAREN #timestampdiff
+ | name=(TIMESTAMPADD | DATEADD) LEFT_PAREN unit=identifier COMMA
unitsAmount=valueExpression COMMA timestamp=valueExpression RIGHT_PAREN
#timestampadd
+ | name=(TIMESTAMPDIFF | DATEDIFF) LEFT_PAREN unit=identifier COMMA
startTimestamp=valueExpression COMMA endTimestamp=valueExpression RIGHT_PAREN
#timestampdiff
Review comment:
Can we define a parser rule `datetimeUnits` which only includes the
accepted units and use it here?
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4
##########
@@ -808,8 +808,8 @@ valueExpression
primaryExpression
: name=(CURRENT_DATE | CURRENT_TIMESTAMP | CURRENT_USER)
#currentLike
- | name=(TIMESTAMPADD | DATEADD | DATE_ADD) LEFT_PAREN unit=identifier
COMMA unitsAmount=valueExpression COMMA timestamp=valueExpression RIGHT_PAREN
#timestampadd
- | name=(TIMESTAMPDIFF | DATEDIFF | DATE_DIFF) LEFT_PAREN unit=identifier
COMMA startTimestamp=valueExpression COMMA endTimestamp=valueExpression
RIGHT_PAREN #timestampdiff
+ | name=(TIMESTAMPADD | DATEADD) LEFT_PAREN unit=identifier COMMA
unitsAmount=valueExpression COMMA timestamp=valueExpression RIGHT_PAREN
#timestampadd
+ | name=(TIMESTAMPDIFF | DATEDIFF) LEFT_PAREN unit=identifier COMMA
startTimestamp=valueExpression COMMA endTimestamp=valueExpression RIGHT_PAREN
#timestampdiff
Review comment:
Can we define a parser rule `datetimeUnit` which only includes the
accepted units and use it here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
