zero323 commented on a change in pull request #35530:
URL: https://github.com/apache/spark/pull/35530#discussion_r825329452
##########
File path: python/pyspark/ml/feature.py
##########
@@ -271,35 +332,35 @@ class _LSHParams(HasInputCol, HasOutputCol):
typeConverter=TypeConverters.toInt,
)
- def __init__(self, *args):
+ def __init__(self, *args: Any) -> None:
super(_LSHParams, self).__init__(*args)
self._setDefault(numHashTables=1)
- def getNumHashTables(self):
+ def getNumHashTables(self) -> int:
"""
Gets the value of numHashTables or its default value.
"""
return self.getOrDefault(self.numHashTables)
-class _LSH(JavaEstimator, _LSHParams, JavaMLReadable, JavaMLWritable):
+class _LSH(Generic[JM], JavaEstimator[JM], _LSHParams, JavaMLReadable,
JavaMLWritable):
Review comment:
With all annotations in `.py` files, generics should be placed at the
last position.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
