zero323 commented on a change in pull request #35766:
URL: https://github.com/apache/spark/pull/35766#discussion_r825325668
##########
File path: python/pyspark/mllib/recommendation.py
##########
@@ -224,7 +228,7 @@ class ALS:
"""
@classmethod
- def _prepare(cls, ratings):
+ def _prepare(cls, ratings: Any) -> RDD:
Review comment:
Return type should be properly annotated with `RDD[Rating]`.
We might also annotate `ratings` as `Union[RDD[???], DataFrame])`, but it is
OK to have `Any` in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
