beliefer commented on a change in pull request #35768:
URL: https://github.com/apache/spark/pull/35768#discussion_r825612324
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
##########
@@ -87,14 +96,21 @@ public String build(Expression expr) {
}
}
- protected String visitLiteral(LiteralValue literalValue) {
- return literalValue.toString();
+ protected String visitLiteral(Literal literal) {
+ return literal.toString();
}
protected String visitFieldReference(FieldReference fieldRef) {
return fieldRef.toString();
}
+ protected String visitIn(String v, List<String> list) {
+ if (list.isEmpty()) {
+ return "CASE WHEN " + v + " IS NULL THEN NULL ELSE FALSE END";
Review comment:
IF is not a SQL standard. Many databases doesn't support it.
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java
##########
@@ -87,14 +96,21 @@ public String build(Expression expr) {
}
}
- protected String visitLiteral(LiteralValue literalValue) {
- return literalValue.toString();
+ protected String visitLiteral(Literal literal) {
+ return literal.toString();
}
protected String visitFieldReference(FieldReference fieldRef) {
return fieldRef.toString();
}
+ protected String visitIn(String v, List<String> list) {
+ if (list.isEmpty()) {
+ return "CASE WHEN " + v + " IS NULL THEN NULL ELSE FALSE END";
Review comment:
`IF` is not a SQL standard. Many databases doesn't support it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
