cloud-fan commented on a change in pull request #35710:
URL: https://github.com/apache/spark/pull/35710#discussion_r825735195
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/SupportsPushDownTopN.java
##########
@@ -31,8 +31,25 @@
@Evolving
public interface SupportsPushDownTopN extends ScanBuilder {
+ enum TopNPushedStatus {
Review comment:
My opinion is that 2 boolean is better than enum in the public API. If
we want to add the same feature to limit pushdown, we won't be able to add enum
for backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
