beliefer commented on a change in pull request #35768:
URL: https://github.com/apache/spark/pull/35768#discussion_r826536150
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
##########
@@ -773,36 +773,36 @@ class JDBCSuite extends QueryTest
}
test("compile filters") {
- val compileFilter = PrivateMethod[Option[String]](Symbol("compileFilter"))
def doCompileFilter(f: Filter): String =
- JDBCRDD invokePrivate compileFilter(f, JdbcDialects.get("jdbc:"))
getOrElse("")
+
f.toV2.flatMap(JdbcDialects.get("jdbc:").compileExpression(_)).getOrElse("")
+
Seq(("col0", "col1"), ("`col0`", "`col1`")).foreach { case(col0, col1) =>
- assert(doCompileFilter(EqualTo(col0, 3)) === """"col0" = 3""")
- assert(doCompileFilter(Not(EqualTo(col1, "abc"))) === """(NOT ("col1" =
'abc'))""")
+ assert(doCompileFilter(EqualTo(col0, 3)) === """("col0") = (3)""")
Review comment:
Because the discussion
https://github.com/apache/spark/pull/35248#discussion_r801712556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
