dongjoon-hyun commented on a change in pull request #35856:
URL: https://github.com/apache/spark/pull/35856#discussion_r827335915



##########
File path: 
sql/core/src/main/scala/org/apache/spark/status/api/v1/sql/ApiSqlRootResource.scala
##########
@@ -31,4 +31,15 @@ private[v1] class ApiSqlRootResource extends 
ApiRequestContext {
   def sqlList(
       @PathParam("appId") appId: String,
       @PathParam("attemptId") attemptId: String): Class[SqlResource] = 
classOf[SqlResource]
+
+  @Path("applications/{appId}/diagnostics")

Review comment:
       If you want to add this in this PR, `REST API` should be documented here.
   - https://spark.apache.org/docs/latest/monitoring.html#rest-api

##########
File path: 
sql/core/src/main/scala/org/apache/spark/status/api/v1/sql/ApiSqlRootResource.scala
##########
@@ -31,4 +31,15 @@ private[v1] class ApiSqlRootResource extends 
ApiRequestContext {
   def sqlList(
       @PathParam("appId") appId: String,
       @PathParam("attemptId") attemptId: String): Class[SqlResource] = 
classOf[SqlResource]
+
+  @Path("applications/{appId}/diagnostics")

Review comment:
       If you want to add this in this PR, `REST API` should be documented here.
   - https://spark.apache.org/docs/latest/monitoring.html#rest-api




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to